Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support certificate authority configuration #380

Merged
merged 8 commits into from
May 16, 2022
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Code clean
Signed-off-by: Billy Zha <[email protected]>
qweeah committed May 11, 2022
commit b07fd1d3e6242bc7a93fa5d88dca4d071ce039ad
2 changes: 0 additions & 2 deletions internal/http/client_test.go
Original file line number Diff line number Diff line change
@@ -35,7 +35,6 @@ func Test_NewClient_credential(t *testing.T) {
Credential: wanted,
}
client := http.NewClient(opts)

got, err := client.(*auth.Client).Credential(nil, "")
if err != nil {
t.Fatalf("unexpected error: %v", err)
@@ -53,7 +52,6 @@ func Test_NewClient_skipTlsVerify(t *testing.T) {

wanted := opts.SkipTLSVerify
client := http.NewClient(opts)

config := client.(*auth.Client).Client.Transport.(*nhttp.Transport).TLSClientConfig
got := config.InsecureSkipVerify
if got != wanted {