Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ut,windows): exclude pty build in Windows tests #1541

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

qweeah
Copy link
Contributor

@qweeah qweeah commented Nov 25, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1540

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.99%. Comparing base (4996e1f) to head (8c4f52a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1541   +/-   ##
=======================================
  Coverage   83.99%   83.99%           
=======================================
  Files         119      119           
  Lines        5306     5306           
=======================================
  Hits         4457     4457           
  Misses        602      602           
  Partials      247      247           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@TerryHowe TerryHowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just building this on windows fails? This builds on osx, but is not used.

My long struggle with this console stuff:
#1474

@qweeah
Copy link
Contributor Author

qweeah commented Nov 25, 2024

Yes, just build failure. I will take a look at #1474 later this week to unblock you.

@TerryHowe
Copy link
Member

TerryHowe commented Nov 25, 2024

Closes: #1540

@TerryHowe TerryHowe merged commit 76eadf2 into oras-project:main Nov 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows unit test cannot be compiled
3 participants