-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ut,windows): exclude pty build in Windows tests #1541
Conversation
Signed-off-by: Billy Zha <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1541 +/- ##
=======================================
Coverage 83.99% 83.99%
=======================================
Files 119 119
Lines 5306 5306
=======================================
Hits 4457 4457
Misses 602 602
Partials 247 247 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just building this on windows fails? This builds on osx, but is not used.
My long struggle with this console stuff:
#1474
Yes, just build failure. I will take a look at #1474 later this week to unblock you. |
Closes: #1540 |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1540
Please check the following list: