-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cp): avoid showing empty descriptor in progress bar #1528
fix(cp): avoid showing empty descriptor in progress bar #1528
Conversation
Signed-off-by: Billy Zha <[email protected]>
Signed-off-by: Billy Zha <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1528 +/- ##
==========================================
+ Coverage 83.87% 83.99% +0.12%
==========================================
Files 118 118
Lines 5166 5174 +8
==========================================
+ Hits 4333 4346 +13
+ Misses 592 588 -4
+ Partials 241 240 -1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Billy Zha <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
…ength-no-progress
…eah/oras into jinzha1/1442-zero-length-no-progress
Signed-off-by: Billy Zha <[email protected]>
Signed-off-by: Billy Zha <[email protected]>
Signed-off-by: Billy Zha <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
…#1528) Signed-off-by: Billy Zha <[email protected]> Co-authored-by: Terry Howe <[email protected]> Signed-off-by: Billy Zha <[email protected]>
What this PR does / why we need it:
This PR fixes progress ratio and missing descriptor in the progress output.
Before
After
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1442
Please check the following list: