-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: create an interface for status console #1481
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1481 +/- ##
==========================================
- Coverage 86.10% 86.05% -0.06%
==========================================
Files 118 118
Lines 4224 4223 -1
==========================================
- Hits 3637 3634 -3
- Misses 350 351 +1
- Partials 237 238 +1 ☔ View full report in Codecov by Sentry. |
4af9db7
to
76ba908
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Terry for contributing. LGTM with minor sugggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with minor suggestions.
Signed-off-by: Terry Howe <[email protected]>
Signed-off-by: Terry Howe <[email protected]>
31dafc0
to
39fbfdb
Compare
Signed-off-by: Terry Howe <[email protected]>
39fbfdb
to
83474e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What this PR does / why we need it:
Create a interface for console so that alternate implementations can exist. In doing this, I found the
Size()
method was not properly implemented, so I created aGetHeightWidth()
method.Partial: #1461