Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Make mock fetcher generally available #1455

Merged
merged 1 commit into from
Aug 4, 2024
Merged

refactor: Make mock fetcher generally available #1455

merged 1 commit into from
Aug 4, 2024

Conversation

TerryHowe
Copy link
Member

What this PR does / why we need it:

I wanted to get a feel for how people felt about making a mock fetcher as a test utility, so I created this small PR.

@codecov Codecov
Copy link

codecov bot commented Jul 24, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 84.61538% with 6 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@82949a2). Learn more about missing BASE report.

Files Patch % Lines
internal/testutils/fetcher.go 84.61% 3 Missing and 3 partials ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1455   +/-   ##
=======================================
  Coverage        ?   83.29%           
=======================================
  Files           ?      110           
  Lines           ?     3892           
  Branches        ?        0           
=======================================
  Hits            ?     3242           
  Misses          ?      426           
  Partials        ?      224

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

qweeah
qweeah requested changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@qweeah qweeah left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I got to confess mocking a fetcher is torturesome so the test code is bad. Thanks for making it better (but you haven't met the mocked registry service yet :) )

@TerryHowe TerryHowe force-pushed the mock-fetcher branch 2 times, most recently from bf0dff3 to f35a8a9 Compare July 28, 2024 12:11
qweeah
qweeah approved these changes Aug 4, 2024
View reviewed changes
Copy link
Contributor

@qweeah qweeah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah qweeah merged commit 25b8d59 into oras-project:main Aug 4, 2024
8 checks passed
@qweeah qweeah mentioned this pull request Dec 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qweeah qweeah qweeah approved these changes

@sajayantony sajayantony Awaiting requested review from sajayantony sajayantony is a code owner

@shizhMSFT shizhMSFT Awaiting requested review from shizhMSFT shizhMSFT is a code owner

@SteveLasker SteveLasker Awaiting requested review from SteveLasker SteveLasker is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TerryHowe @qweeah