Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Move channel write logic to manager #1445

Merged
merged 1 commit into from
Jul 13, 2024

Conversation

TerryHowe
Copy link
Member

What this PR does / why we need it:

Move these progress bar channel operations out of handler and into the manager.

Copy link

codecov bot commented Jul 13, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.41%. Comparing base (d06bb81) to head (f16a833).

Files Patch % Lines
...d/oras/internal/display/status/progress/manager.go 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1445      +/-   ##
==========================================
- Coverage   85.46%   85.41%   -0.05%     
==========================================
  Files         108      108              
  Lines        3825     3827       +2     
==========================================
  Hits         3269     3269              
- Misses        332      334       +2     
  Partials      224      224              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@qweeah qweeah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will check if SendAndStop helps refactoring Prompt usage next week.

@TerryHowe
Copy link
Member Author

LGTM, will check if SendAndStop helps refactoring Prompt usage next week.

Sounds good. I was thinking there might be something there, but no clear vision of what right now.

@TerryHowe TerryHowe merged commit 9e5e766 into oras-project:main Jul 13, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants