Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove last deprecated method #1438

Merged
merged 2 commits into from
Jul 3, 2024

Conversation

TerryHowe
Copy link
Member

What this PR does / why we need it:

Remove the last deprecated method

Copy link

codecov bot commented Jul 1, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.31%. Comparing base (374a1e3) to head (2555456).

Files Patch % Lines
cmd/oras/root/cp.go 66.66% 0 Missing and 1 partial ⚠️
cmd/oras/root/manifest/push.go 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1438      +/-   ##
==========================================
+ Coverage   85.28%   85.31%   +0.02%     
==========================================
  Files         107      106       -1     
  Lines        3800     3800              
==========================================
+ Hits         3241     3242       +1     
+ Misses        334      333       -1     
  Partials      225      225              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@qweeah qweeah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I can see oras cp and oras manifest push still require a lot of refactoring. Thanks @TerryHowe

@TerryHowe
Copy link
Member Author

LGTM but I can see oras cp and oras manifest push still require a lot of refactoring. Thanks @TerryHowe

I'll look at those next, thanks.

@qweeah qweeah merged commit f649643 into oras-project:main Jul 3, 2024
7 of 8 checks passed
@qweeah
Copy link
Contributor

qweeah commented Jul 3, 2024

LGTM but I can see oras cp and oras manifest push still require a lot of refactoring. Thanks @TerryHowe

I'll look at those next, thanks.

Thanks, the main idea is to create dedicated display handler for cp and manifest push that implements a TaggedHandler like https://github.com/oras-project/oras/blob/f64964319489e88e4842d20b28428d1ffd065206/cmd/oras/internal/display/metadata/text/push.go#L41C1-L45C2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants