Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Create tag handlers #1437

Merged
merged 4 commits into from
Jul 1, 2024
Merged

Conversation

TerryHowe
Copy link
Member

What this PR does / why we need it:

Create a tag handler for tagging

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.23%. Comparing base (ecb7878) to head (3b6994f).

Current head 3b6994f differs from pull request most recent head 5589399

Please upload reports for the commit 5589399 to get more accurate results.

Files Patch % Lines
cmd/oras/root/tag.go 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1437   +/-   ##
=======================================
  Coverage   85.22%   85.23%           
=======================================
  Files         106      107    +1     
  Lines        3798     3800    +2     
=======================================
+ Hits         3237     3239    +2     
  Misses        336      336           
  Partials      225      225           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qweeah
Copy link
Contributor

qweeah commented Jun 29, 2024

Will take a look next week. Happy weekend!

Copy link
Contributor

@qweeah qweeah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some comment changes.

cmd/oras/internal/display/metadata/text/tag.go Outdated Show resolved Hide resolved
cmd/oras/internal/display/metadata/text/tag.go Outdated Show resolved Hide resolved
@TerryHowe TerryHowe merged commit 374a1e3 into oras-project:main Jul 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants