Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: clean status prompts #1409

Merged
merged 5 commits into from
Jun 17, 2024
Merged

Conversation

qweeah
Copy link
Contributor

@qweeah qweeah commented Jun 17, 2024

What this PR does / why we need it:
As a follow up to #1407, this PR aligns the prompts naming for status handlers.

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.14%. Comparing base (e0b7cdd) to head (4d172e6).

Files Patch % Lines
cmd/oras/internal/display/status/text.go 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1409      +/-   ##
==========================================
+ Coverage   84.96%   85.14%   +0.18%     
==========================================
  Files         107      107              
  Lines        3790     3790              
==========================================
+ Hits         3220     3227       +7     
+ Misses        341      336       -5     
+ Partials      229      227       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@TerryHowe TerryHowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@TerryHowe TerryHowe merged commit 2aa005c into oras-project:main Jun 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants