Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: using const to replace string #1316

Merged
merged 2 commits into from
Apr 1, 2024
Merged

chore: using const to replace string #1316

merged 2 commits into from
Apr 1, 2024

Conversation

LinuxSuRen
Copy link
Contributor

Signed-off-by: rick [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

@codecov Codecov
Copy link

codecov bot commented Mar 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.30%. Comparing base (bf18775) to head (44301c3).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1316      +/-   ##
==========================================
- Coverage   82.35%   82.30%   -0.05%     
==========================================
  Files          83       83              
  Lines        4036     4036              
==========================================
- Hits         3324     3322       -2     
- Misses        492      494       +2     
  Partials      220      220

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

TerryHowe
TerryHowe approved these changes Mar 30, 2024
View reviewed changes
Copy link
Member

@TerryHowe TerryHowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

qweeah
qweeah approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@qweeah qweeah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah
Copy link
Contributor

qweeah commented Apr 1, 2024

Thanks for contributing @LinuxSuRen.

@qweeah qweeah merged commit c24ac15 into oras-project:main Apr 1, 2024
8 checks passed
@LinuxSuRen LinuxSuRen deleted the chore/using-const branch April 1, 2024 02:08
FeynmanZhou pushed a commit to FeynmanZhou/oras that referenced this pull request May 11, 2024
@LinuxSuRen @FeynmanZhou
chore: using const to replace string (oras-project#1316)
44677ea 
Signed-off-by: rick <[email protected]>
Co-authored-by: rick <[email protected]>
Co-authored-by: Terry Howe <[email protected]>
@qweeah qweeah mentioned this pull request May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qweeah qweeah qweeah approved these changes

@TerryHowe TerryHowe TerryHowe approved these changes

@sajayantony sajayantony Awaiting requested review from sajayantony sajayantony is a code owner

@shizhMSFT shizhMSFT Awaiting requested review from shizhMSFT shizhMSFT is a code owner

@SteveLasker SteveLasker Awaiting requested review from SteveLasker SteveLasker is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LinuxSuRen @qweeah @TerryHowe