Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add stdout to metadata handlers #1312

Merged
merged 4 commits into from
Mar 28, 2024
Merged

Conversation

qweeah
Copy link
Contributor

@qweeah qweeah commented Mar 27, 2024

What this PR does / why we need it:
This PR adds stdout to the metadata handlers.

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.10%. Comparing base (776f8df) to head (21cbef3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1312      +/-   ##
==========================================
+ Coverage   81.99%   82.10%   +0.11%     
==========================================
  Files          83       83              
  Lines        4016     4030      +14     
==========================================
+ Hits         3293     3309      +16     
+ Misses        500      498       -2     
  Partials      223      223              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'd expect the next PR for add out to status handlers.

@qweeah qweeah merged commit 24c2acf into oras-project:main Mar 28, 2024
8 checks passed
@qweeah qweeah deleted the add-output branch March 28, 2024 03:55
FeynmanZhou pushed a commit to FeynmanZhou/oras that referenced this pull request May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants