Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(actions): update github actions for Node 20 #1287

Merged
merged 4 commits into from
Mar 15, 2024

Conversation

TerryHowe
Copy link
Member

What this PR does / why we need it:

Node 16 is deprecated and the v3 actions use it. These actions are available with a Node 20 runner with v4.

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.49%. Comparing base (ec23755) to head (54cbb39).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1287      +/-   ##
==========================================
+ Coverage   81.99%   84.49%   +2.49%     
==========================================
  Files          83       83              
  Lines        4005     3276     -729     
==========================================
- Hits         3284     2768     -516     
+ Misses        498      285     -213     
  Partials      223      223              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qweeah
Copy link
Contributor

qweeah commented Mar 14, 2024

@TerryHowe Can you help make the PR title complaint to conventional commits? E.g. for this PR it can be build(actions): update to Node 20

@TerryHowe TerryHowe changed the title Update github actions for Node 20 build(actions): Update github actions for Node 20 Mar 14, 2024
@qweeah qweeah changed the title build(actions): Update github actions for Node 20 build(actions): update github actions for Node 20 Mar 15, 2024
Copy link
Contributor

@qweeah qweeah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah qweeah merged commit 61a8f49 into oras-project:main Mar 15, 2024
8 checks passed
FeynmanZhou pushed a commit to FeynmanZhou/oras that referenced this pull request May 11, 2024
@TerryHowe TerryHowe deleted the github-actions branch May 27, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants