Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump: update golang to 1.22 #1282

Merged
merged 4 commits into from
Apr 2, 2024
Merged

bump: update golang to 1.22 #1282

merged 4 commits into from
Apr 2, 2024

Conversation

TerryHowe
Copy link
Member

@TerryHowe TerryHowe commented Mar 12, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1275

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@qweeah qweeah changed the title Update go to 1.22 bump: update golang to 1.22 Mar 12, 2024
@qweeah
Copy link
Contributor

qweeah commented Mar 12, 2024

@TerryHowe oras-go fails 1.22 bump, this PR is pending on the merging of oras-project/oras-go#715

@qweeah qweeah mentioned this pull request Mar 12, 2024
4 tasks
@wangxiaoxuan273
Copy link
Contributor

We also need to update .github/workflows/build.yml

Signed-off-by: Terry Howe <[email protected]>
@TerryHowe
Copy link
Member Author

.github/workflows/build.yml

updated

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.39%. Comparing base (c24ac15) to head (b0fbae8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1282      +/-   ##
==========================================
- Coverage   82.30%   81.39%   -0.92%     
==========================================
  Files          83       84       +1     
  Lines        4036     4084      +48     
==========================================
+ Hits         3322     3324       +2     
- Misses        494      540      +46     
  Partials      220      220              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@qweeah qweeah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TerryHowe TerryHowe merged commit f6dca87 into oras-project:main Apr 2, 2024
8 checks passed
FeynmanZhou pushed a commit to FeynmanZhou/oras that referenced this pull request May 11, 2024
Signed-off-by: Terry Howe <[email protected]>
Co-authored-by: Billy Zha <[email protected]>
@TerryHowe TerryHowe deleted the go1-22 branch May 27, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bump: update golang to 1.22
4 participants