chore: Bring back the print error (#1451)

Signed-off-by: Terry Howe <[email protected]>
oras-project · Jul 23, 2024 · 341ceb8 · 341ceb8
1 parent 18f496c
commit 341ceb8
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/cmd/oras/internal/display/metadata/text/push_test.go b/cmd/oras/internal/display/metadata/text/push_test.go
@@ -60,7 +60,7 @@ func TestPushHandler_OnCompleted(t *testing.T) {
 				Digest:    digest.FromBytes(content),
 				Size:      int64(len(content)),
 			},
-			false, // Printer ignores error
+			true,
 		},
 	}
 	for _, tt := range tests {

diff --git a/cmd/oras/internal/output/print.go b/cmd/oras/internal/output/print.go
@@ -58,8 +58,8 @@ func (p *Printer) Println(a ...any) error {
 	if err != nil {
 		err = fmt.Errorf("display output error: %w", err)
 		_, _ = fmt.Fprint(p.err, err)
+		return err
 	}
-	// Errors are handled above, so return nil
 	return nil
 }
 

diff --git a/cmd/oras/internal/output/print_test.go b/cmd/oras/internal/output/print_test.go
@@ -48,8 +48,8 @@ func TestPrinter_Println(t *testing.T) {
 	if mockWriter.errorCount != 1 {
 		t.Error("Expected one error actual <" + strconv.Itoa(mockWriter.errorCount) + ">")
 	}
-	if err != nil {
-		t.Error("Expected error to be ignored")
+	if err == nil {
+		t.Error("Expected error got <nil>")
 	}
 	err = printer.Printf("boom")
 	if mockWriter.errorCount != 2 {