Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolves make truncate warning #401

Merged
merged 1 commit into from
Oct 18, 2024
Merged

fix: resolves make truncate warning #401

merged 1 commit into from
Oct 18, 2024

Conversation

TerryHowe
Copy link
Member

@TerryHowe TerryHowe commented Oct 15, 2024 •
edited
Loading

Gets rid of this warning:

[WARNING] Docusaurus found blog posts without truncation markers:
- "blog/2024-05-29-oras-1.2.0-and-oras-go-2.5.0/index.mdx"

We recommend using truncation markers (`<!-- truncate -->` or `{/* truncate */}`) in blog posts to create shorter previews on blog paginated lists.
Tip: turn this security off with the `onUntruncatedBlogPosts: 'ignore'` blog plugin option.

@TerryHowe
Copy link
Member Author

This just needs a rebase after #402 merges

FeynmanZhou
FeynmanZhou approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@FeynmanZhou FeynmanZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FeynmanZhou
Copy link
Member

@TerryHowe I reviewed and approved both #402 and #401. Thanks

@TerryHowe TerryHowe merged commit 361d185 into oras-project:main Oct 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FeynmanZhou FeynmanZhou FeynmanZhou approved these changes

@asmitbm asmitbm Awaiting requested review from asmitbm asmitbm is a code owner

@sajayantony sajayantony Awaiting requested review from sajayantony sajayantony is a code owner

@shizhMSFT shizhMSFT Awaiting requested review from shizhMSFT shizhMSFT is a code owner

@SteveLasker SteveLasker Awaiting requested review from SteveLasker SteveLasker is a code owner

@vsoch vsoch Awaiting requested review from vsoch vsoch is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TerryHowe @FeynmanZhou