Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Artifactory as a Compatible OCI Registry #394

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

martinezlc99
Copy link
Contributor

At my day job, we use Artifactory and have started to use it as an OCI registry. When researching this, it was not clear oras supported Artifactory. This PR is to update the applicable documentation.

Closes #393.

Closes #205.

@martinezlc99 martinezlc99 changed the title Add Artifactory as an Compatible OCI Registry Add Artifactory as a Compatible OCI Registry Sep 15, 2024
Copy link
Member

@TerryHowe TerryHowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@FeynmanZhou FeynmanZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FeynmanZhou
Copy link
Member

FeynmanZhou commented Sep 17, 2024

@martinezlc99 BTW, is Artifactory compliant with OCI Spec v.1.1 or v1.0?

@TerryHowe
Copy link
Member

The blog post for 12/23 said v1.0

@martinezlc99
Copy link
Contributor Author

@martinezlc99 BTW, is Artifactory compliant with OCI Spec v.1.1 or v1.0?

@FeynmanZhou - as far as I know, Artifactory is OCI Spec v1.0. There is an OCI Spec v1.1 pre-release in the blog post referenced (since Dec 2023), but difficult to tell what's actually implemented. I am mainly using our Artifactory instance for devcontainer features, which is working very well.

Is there a test I can perform to verify an OCI Spec v1.1 feature? Looking here, oras discover and oras attach are working with Artifactory.

BTW, I am personally very excited about OCI registries and looking to learn more so we can start using at my day job. Any suggestions on how to learn more and potentially contribute would be welcome.

@TerryHowe
Copy link
Member

Feedback on PRs and issue grooming is always appreciated @martinezlc99 . Meeting in ~3.5 hours as well https://oras.land/community/community_resources

@FeynmanZhou
Copy link
Member

@martinezlc99 I checked that JFrog Artifactory is OCI v1.1 compliant because JFrog already passed the OCI v1.1 conformance test and uploaded its report to https://github.com/opencontainers/oci-conformance/tree/main/distribution-spec/v1.1/artifactory

@FeynmanZhou FeynmanZhou merged commit 1b3354c into oras-project:main Sep 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Add adopter]: Artifactory [Documentation Feedback]: Add JFrog Artifactory's documentation
3 participants