Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCI store should support discovering predecessors that are not tagged #342

Closed
Wwwsylvia opened this issue Oct 11, 2022 · 2 comments · Fixed by #385
Closed

OCI store should support discovering predecessors that are not tagged #342

Wwwsylvia opened this issue Oct 11, 2022 · 2 comments · Fixed by #385
Assignees
@Wwwsylvia
Labels
enhancement New feature or request
Milestone
v2.0.0-rc.6

Comments

@Wwwsylvia
Copy link
Member

Wwwsylvia commented Oct 11, 2022 •
edited
Loading

Currently, when restoring from an existing OCI layout, the OCI store will index the predecessor relationships for all the manifests in index.json, which are tagged manifests.
However, the predecessors of manifests are usually not tagged and are not present in index.json.
As a result, these predecessors will not be indexed, and they cannot be discovered by the Predecessors() function of the OCI store. This blocks scenarios like extended-copying a graph from an OCI store that is restored from an existing OCI layout to other Targets.
@Wwwsylvia Wwwsylvia added the enhancement New feature or request label Oct 11, 2022
@Wwwsylvia Wwwsylvia added this to the v2.0.0-rc.5 milestone Oct 11, 2022
@Wwwsylvia Wwwsylvia changed the title OCI store should support discovering predecessors that are not in index.json OCI store should support discovering predecessors that are not tagged Oct 11, 2022
@shizhMSFT
Copy link
Contributor

We can apply tag schema in the distribution-spec to OCI layout.

@yizha1 yizha1 modified the milestones: v2.0.0-rc.5, v2.0.0-rc.6 Oct 31, 2022
@shizhMSFT
Copy link
Contributor

The implementation of zot gives an idea that we can store un-tagged manifests in the index.json so that predecessors can be indexed without a tag schema.

@Wwwsylvia Wwwsylvia mentioned this issue Dec 12, 2022
Merged
Wwwsylvia added a commit that referenced this issue Dec 12, 2022
@Wwwsylvia
refactor: refactor OCI store to fully support Predecessors() and `R…
4e58192 
…esolve()` (#385)

1. Support discovering predecessors that are not tagged
2. Support resolving a manifest by its digest
3. Support resolving a blob by its digest

Resolves: #342
Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
@Wwwsylvia Wwwsylvia moved this to Done in ORAS-Planning Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Wwwsylvia Wwwsylvia

Labels
enhancement New feature or request
Projects
No open projects
ORAS-Planning
Status: Done
Milestone
v2.0.0-rc.6
Development

Successfully merging a pull request may close this issue.

refactor: refactor OCI store to fully support Predecessors() and Resolve() Wwwsylvia/oras-go
3 participants
@Wwwsylvia @shizhMSFT @yizha1