Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add cloudavenue_s3_bucket_lifecycle_configuration #602

Merged
merged 2 commits into from
Oct 31, 2023
Merged

feat: add cloudavenue_s3_bucket_lifecycle_configuration #602

merged 2 commits into from
Oct 31, 2023

Conversation

azrod
Copy link
Member

@azrod azrod commented Oct 31, 2023 •
edited
Loading

Description of your changes

If you submit change in the provider code, please make sure to:

  • Write or modify examples in examples/ directory
  • Write or modify acceptance tests
  • Run make generate to ensure the doc was updated properly

How has this code been tested

--- PASS: TestAccS3BucketLifecycleConfigurationResource (755.65s)
PASS
ok      github.com/orange-cloudavenue/terraform-provider-cloudavenue/internal/testsacc  756.193s

--- PASS: TestAccS3BucketLifecycleConfigurationDataSource (103.80s)
PASS
ok      github.com/orange-cloudavenue/terraform-provider-cloudavenue/internal/testsacc  104.492s

@azrod azrod linked an issue Oct 31, 2023 that may be closed by this pull request
[New Resource/Datasource]: Add feature cloudavenue_s3_bucket_lifecycle_configuration #579
Closed
@crown-app crown-app
Copy link

crown-app bot commented Oct 31, 2023

Thank you for your contribution, but this PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR.
Note this PR might be rejected due to its size.

@azrod azrod force-pushed the 579-new-resourcedatasource-add-feature-cloudavenue_s3_bucket_lifecycle_configuration branch 5 times, most recently from 927cec3 to 325a498 Compare October 31, 2023 15:02
@azrod azrod marked this pull request as ready for review October 31, 2023 15:03
@azrod azrod requested a review from a team as a code owner October 31, 2023 15:03
@azrod azrod force-pushed the 579-new-resourcedatasource-add-feature-cloudavenue_s3_bucket_lifecycle_configuration branch 2 times, most recently from 40d07e7 to 391f635 Compare October 31, 2023 15:22
@azrod azrod force-pushed the 579-new-resourcedatasource-add-feature-cloudavenue_s3_bucket_lifecycle_configuration branch from 391f635 to 7ef5d82 Compare October 31, 2023 16:51
@crown-app crown-app bot added the Fix label Oct 31, 2023
@azrod azrod merged commit b68766d into main Oct 31, 2023
4 checks passed
@azrod azrod deleted the 579-new-resourcedatasource-add-feature-cloudavenue_s3_bucket_lifecycle_configuration branch October 31, 2023 16:57
azrod pushed a commit that referenced this pull request Oct 31, 2023
chore: update CHANGELOG.md for #602
8734dce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmicheneau dmicheneau dmicheneau approved these changes

Assignees
No one assigned
Labels
Feature Fix size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[New Resource/Datasource]: Add feature cloudavenue_s3_bucket_lifecycle_configuration
2 participants
@azrod @dmicheneau