Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: remove attributs is_fenced and retain_ip_mac_enabled #540

Merged
merged 1 commit into from
Sep 22, 2023
Merged

fix!: remove attributs is_fenced and retain_ip_mac_enabled #540

merged 1 commit into from
Sep 22, 2023

Conversation

azrod
Copy link
Member

@azrod azrod commented Sep 22, 2023

Description of your changes

If you submit change in the provider code, please make sure to:

  • Write or modify examples in examples/ directory
  • Write or modify acceptance tests
  • Run make generate to ensure the doc was updated properly

How has this code been tested

=== RUN   TestAccOrgNetworkResource
--- PASS: TestAccOrgNetworkResource (488.83s)
PASS
ok      github.com/orange-cloudavenue/terraform-provider-cloudavenue/internal/testsacc  489.398s

@azrod azrod requested a review from a team as a code owner September 22, 2023 13:14
@azrod azrod linked an issue Sep 22, 2023 that may be closed by this pull request
Breaking Change: Remove is_fenced and retain_ip_mac_enabled in cloudavenue_vapp_org_network #538
Closed
@crown-app crown-app bot added the Fix label Sep 22, 2023
@azrod azrod force-pushed the 538-breaking-change-remove-is_fenced-and-retain_ip_mac_enabled-in-cloudavenue_vapp_org_network branch from 3fc267e to 0974918 Compare September 22, 2023 13:14
This was linked to issues Sep 22, 2023
[Bug]: Failed to update retain_ip_mac_enabledattribute in cloudavenue_vapp_org_network #531
Closed
[Bug]: Fenced attribute is not allowed in cloudavenue_vapp_org_network #529
Closed
@dmicheneau dmicheneau merged commit a175791 into main Sep 22, 2023
4 checks passed
@dmicheneau dmicheneau deleted the 538-breaking-change-remove-is_fenced-and-retain_ip_mac_enabled-in-cloudavenue_vapp_org_network branch September 22, 2023 13:19
gaetanars pushed a commit that referenced this pull request Sep 22, 2023
chore: update CHANGELOG.md for #540
33c2984
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmicheneau dmicheneau dmicheneau approved these changes

Assignees
No one assigned
Labels
BreakingChange Fix size/M
Projects
None yet
Milestone
No milestone
2 participants
@azrod @dmicheneau