Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add resource/datasource cloudavenue_edgegateway_nat_rule #434

Merged
merged 15 commits into from
Aug 1, 2023
Merged

feat: add resource/datasource cloudavenue_edgegateway_nat_rule #434

merged 15 commits into from
Aug 1, 2023

Conversation

azrod
Copy link
Member

@azrod azrod commented Jul 26, 2023 •
edited by dmicheneau
Loading

Description of your changes

If you submit change in the provider code, please make sure to:

  • Write or modify examples in examples/ directory
  • Write or modify acceptance tests
  • Run make generate to ensure the doc was updated properly

How has this code been tested

=== RUN   TestAccNatRuleDataSource
--- PASS: TestAccNatRuleDataSource (162.31s)
PASS
ok      github.com/orange-cloudavenue/terraform-provider-cloudavenue/internal/tests/edgegw      162.677s

=== RUN   TestAccNATRuleResource
--- PASS: TestAccNATRuleResource (730.44s)
PASS
ok      github.com/orange-cloudavenue/terraform-provider-cloudavenue/internal/tests/edgegw      730.746s

@azrod azrod linked an issue Jul 26, 2023 that may be closed by this pull request
[New Resource]: Add cloudavenue_edgegateway_nat_rule #355
Closed
@crown-app crown-app bot added Feature size/L Large PR labels Jul 26, 2023
@crown-app
Copy link

crown-app bot commented Jul 26, 2023

Thank you for your contribution, but this PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR.
Note this PR might be rejected due to its size.

@crown-app crown-app bot added Chore size/XL Extra large PR and removed size/L Large PR labels Jul 26, 2023
@dmicheneau dmicheneau force-pushed the 355-new-resource-add-cloudavenue_edgegateway_nat_rule branch from 898639e to c9c3b6d Compare July 26, 2023 16:13
@dmicheneau dmicheneau marked this pull request as ready for review July 26, 2023 16:14
@dmicheneau dmicheneau requested a review from a team as a code owner July 26, 2023 16:14
azrod
azrod commented Jul 27, 2023
View reviewed changes
@dmicheneau dmicheneau force-pushed the 355-new-resource-add-cloudavenue_edgegateway_nat_rule branch 2 times, most recently from de802e4 to 622bbf3 Compare July 27, 2023 13:21
David MICHENEAU and others added 13 commits July 27, 2023 15:28
feat: Add New Resource cloudavenue_edgegateway_nat_rule
97feef0
feat: Add New DataSource cloudavenue_edgegateway_nat_rule
faabda8
chore: Add Test ACC cloudavenue_edgegateway_nat_rule
e045d6e
@dmicheneau
chore(script): changes by ci ListingRD (generate_listing)
fef224d
chore: Add Doc / examples / templates cloudavenue_edgegateway_nat_rule
56ea93a
@dmicheneau
chore(script): changes by ci ListingRD (generate_listing)
48a67dc
@dmicheneau @azrod
chore: .changelog/355.txt
7fd7e29 
Co-authored-by: Mickael Stanislas <[email protected]>
@dmicheneau
chore(script): changes by ci ListingRD (generate_listing)
c5deed7
@dmicheneau @azrod
chore: Update .changelog/355.txt
1616200 
Co-authored-by: Mickael Stanislas <[email protected]>
@dmicheneau
chore(script): changes by ci ListingRD (generate_listing)
8cf3cf2
@dmicheneau @azrod
chore: Update docs/data-sources/edgegateway_nat_rule.md
8f459d7 
Co-authored-by: Mickael Stanislas <[email protected]>
@dmicheneau
chore(script): changes by ci ListingRD (generate_listing)
c73b00b
chore: Fix Test / Doc / Examples cloudavenue_edgegateway_nat_rule
4ae2dad
@dmicheneau dmicheneau force-pushed the 355-new-resource-add-cloudavenue_edgegateway_nat_rule branch from 622bbf3 to 4ae2dad Compare July 27, 2023 13:31
@dmicheneau dmicheneau self-assigned this Jul 27, 2023
@dmicheneau dmicheneau force-pushed the 355-new-resource-add-cloudavenue_edgegateway_nat_rule branch from f903faa to 1ba988f Compare July 27, 2023 16:06
@dmicheneau dmicheneau force-pushed the 355-new-resource-add-cloudavenue_edgegateway_nat_rule branch 4 times, most recently from e022995 to 60bc922 Compare July 27, 2023 16:45
azrod
azrod commented Jul 27, 2023
View reviewed changes
@dmicheneau dmicheneau force-pushed the 355-new-resource-add-cloudavenue_edgegateway_nat_rule branch from 60bc922 to 06808ed Compare July 28, 2023 14:34
@dmicheneau dmicheneau force-pushed the 355-new-resource-add-cloudavenue_edgegateway_nat_rule branch 2 times, most recently from d844475 to 10277f4 Compare August 1, 2023 12:44
@dmicheneau dmicheneau force-pushed the 355-new-resource-add-cloudavenue_edgegateway_nat_rule branch 3 times, most recently from 3b1b468 to 15b2cf6 Compare August 1, 2023 13:31
@dmicheneau dmicheneau force-pushed the 355-new-resource-add-cloudavenue_edgegateway_nat_rule branch from 15b2cf6 to 12c41cc Compare August 1, 2023 13:35
@dmicheneau dmicheneau merged commit a8cff8f into main Aug 1, 2023
@dmicheneau dmicheneau deleted the 355-new-resource-add-cloudavenue_edgegateway_nat_rule branch August 1, 2023 13:37
gaetanars pushed a commit that referenced this pull request Aug 1, 2023
chore: update CHANGELOG.md for #434
139dbbb
@dmicheneau dmicheneau mentioned this pull request Aug 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmicheneau dmicheneau dmicheneau left review comments

Assignees

@dmicheneau dmicheneau

Labels
size/XL Extra large PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[New Resource]: Add cloudavenue_edgegateway_nat_rule
2 participants
@azrod @dmicheneau