Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add resource/datasource cloudavenue_edgegateway_security_group #368

Merged

Conversation

azrod
Copy link
Member

@azrod azrod commented Jul 6, 2023

Description of your changes

Add new resource and datasource cloudavenue_edgegateway_security_group

If you submit change in the provider code, please make sure to:

  • Write or modify examples in examples/ directory
  • Write or modify acceptance tests
  • Run make generate to ensure the doc was updated properly

How has this code been tested

Resource

 TF_ACC=1 go test -v -count=1 -timeout 720m  -run TestAccSecurityGroupResource  ./internal/tests/edgegw
=== RUN   TestAccSecurityGroupResource
--- PASS: TestAccSecurityGroupResource (168.52s)
PASS
ok      github.com/orange-cloudavenue/terraform-provider-cloudavenue/internal/tests/edgegw      169.029s

Datasource

TF_ACC=1 go test -v -count=1 -timeout 720m  -run TestAccSecurityGroupDataSource  ./internal/tests/edgegw
=== RUN   TestAccSecurityGroupDataSource
--- PASS: TestAccSecurityGroupDataSource (91.60s)
PASS
ok      github.com/orange-cloudavenue/terraform-provider-cloudavenue/internal/tests/edgegw      92.167s

@azrod azrod self-assigned this Jul 6, 2023
@azrod azrod linked an issue Jul 6, 2023 that may be closed by this pull request
@crown-app crown-app bot added Feature size/XL Extra large PR labels Jul 6, 2023
@azrod azrod changed the title 342 new resource cloudavenue network security group resource feat: add resource/datasource cloudavenue_edgegateway_security_group Jul 6, 2023
@crown-app
Copy link

crown-app bot commented Jul 6, 2023

Thank you for your contribution, but this PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR.
Note this PR might be rejected due to its size.

@azrod azrod linked an issue Jul 6, 2023 that may be closed by this pull request
@crown-app crown-app bot added the Chore label Jul 6, 2023
@azrod azrod requested a review from dmicheneau July 6, 2023 15:14
@azrod azrod force-pushed the 342-new-resource-cloudavenue_network_security_group-resource branch from a6338ba to 70ab4d0 Compare July 6, 2023 15:15
@crown-app crown-app bot added the Fix label Jul 6, 2023
@azrod azrod marked this pull request as ready for review July 6, 2023 15:17
@orange-cloudavenue orange-cloudavenue deleted a comment from crown-app bot Jul 6, 2023
@azrod azrod force-pushed the 342-new-resource-cloudavenue_network_security_group-resource branch from 70ab4d0 to 181a50b Compare July 6, 2023 16:55
@crown-app crown-app bot removed Chore labels Jul 6, 2023
@azrod azrod force-pushed the 342-new-resource-cloudavenue_network_security_group-resource branch from 181a50b to a6e1e02 Compare July 7, 2023 06:28
@azrod azrod requested a review from dmicheneau July 7, 2023 06:31
@dmicheneau dmicheneau merged commit b4f5ca3 into main Jul 7, 2023
@dmicheneau dmicheneau deleted the 342-new-resource-cloudavenue_network_security_group-resource branch July 7, 2023 09:47
gaetanars pushed a commit that referenced this pull request Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XL Extra large PR
Projects
None yet
2 participants