Adding an OffsetDateTimeExtractor, deprecating a DateExtractor constructor #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onstructors deprecated because it doesn't properly preserve the provenance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a
FieldExtractorthat can process date times to go with the one that can process dates. This one usesOffsetDateTimeto capture timezone information. It's possible we'll need aLocalDateTimeone for fields without time zone information asOffsetDateTimerequires it and will fail to parse otherwise.Also it deprecates the
DateExtractorconstructor which accepts aDateTimeFormatteras it's not possible to recover the format string out of such an object, and so the provenance isn't convertible into a configuration. It does however add the toString of the formatter which should be useful for figuring out what the original date format string was even if it can't be automatically generated.Motivation
Fixes a bug in the
DateExtractors provenance and adds a timestamp capability to theRowProcessors metadata extraction.