Added support for full set of XGBoost feature importance metrics #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Craigacp
requested changes
Sep 30, 2020
| */ | ||
| public static class XGBoostFeatureImportanceRecord { | ||
|
|
||
| private String featureName; |
There was a problem hiding this comment.
The feature name should be final.
| } | ||
|
|
||
| private Booster booster; | ||
| private ImmutableFeatureMap featureMap; |
There was a problem hiding this comment.
Fields probably should be final.
|
|
||
| /** | ||
| */ | ||
| public List<XGBoostFeatureImportanceRecord> getImportances() { |
| * @param numFeatures number of features to return | ||
| * @return records of all importance metrics for each feature, sorted by gain. | ||
| */ | ||
| public List<XGBoostFeatureImportanceRecord> getImportances(int numFeatures) { |
| } | ||
|
|
||
| public String toString() { | ||
| return "XGBoostFeatureImportance(" + getImportances(5).stream() |
There was a problem hiding this comment.
That's a toString that generates an awful lot of garbage. Do we even want a toString here given it does computation?
| * An instance of feature importance values for a single feature. See {@link XGBoostFeatureImportance} for details | ||
| * on interpreting the metrics. | ||
| */ | ||
| public static class XGBoostFeatureImportanceRecord { |
There was a problem hiding this comment.
I'm dubious about giving this a name including "Record" given it's not a record yet, and calling records "somethingRecord" sounds a bit odd.
There was a problem hiding this comment.
How about XGBoostFeatureImportanceInstance?
Craigacp
reviewed
Sep 30, 2020
| return "XGBoostFeatureImportance(" + getImportances(5).stream() | ||
| .map(XGBoostFeatureImportanceRecord::toString) | ||
| .collect(Collectors.joining(",\n\t")) + ")"; | ||
| return String.format("XGBoostFeatureImportance(booster=%s, featureIdMap=%s)", booster.toString(), featureMap.toString()); |
There was a problem hiding this comment.
I think it might be better to return a toString that refers to the model provenance? The booster and featureIdMap toStrings aren't very helpful.
…ng importance method te `XGBoostExternalModel`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding richer feature importance support to XGBoost modeling to get parity with other XGBoost wrappers.