Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds SGD protobuf serialization #275

Merged
merged 1 commit into from
Sep 21, 2022
Merged

Adds SGD protobuf serialization #275

merged 1 commit into from
Sep 21, 2022

Conversation

Craigacp
Copy link
Member

Description

Adds protobuf serialization to the SGD models (CRF, FM, linear, Kernel SVM).

Motivation

We need to move off Java serialization.

@Craigacp Craigacp added the squash-commits Squash the commits when merging this PR label Sep 12, 2022
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Sep 12, 2022
pogren
pogren approved these changes Sep 21, 2022
View reviewed changes
Copy link
Member

@pogren pogren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. code test code coverage.

@Craigacp Craigacp merged commit 35c79cb into main Sep 21, 2022
@Craigacp Craigacp deleted the sgd-serialization branch September 21, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pogren pogren pogren approved these changes

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement. squash-commits Squash the commits when merging this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Craigacp @pogren