Protobuf serialization for math types #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lizer, NeighboursQueryFactory. Building out the tensor protos.
…hbour query factories.
oracle-contributor-agreement
bot
added
the
OCA Verified
pogren
approved these changes
Aug 25, 2022
There was a problem hiding this comment.
- Parameters, Kernel, VectorNormalizaer, Tensor, etc. interfaces are now ProtoSerializable and a bunch of impls implement serialize and deserializeFromProto
- added a bunch of equals, hashCode, constructors, and factory methods to support this
- added Util.product method
Everything here looks straightforward and much of the code has reasonable unit tests. A few classes e.g. CRFParameter and FMParameters could use some unit testing for the proto serializable.
|
I plan to add serialization unit tests for CRFModel when we get to that point which will necessarily test CRFParameters rather than individually unit testing CRFParameters. Ditto for FMParameters. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
ProtoSerializableto all serializable types intribuo-mathand their subclasses. A more detailed description of the overall protobuf plan is given in #226.Motivation
We need to move off Java Serialization.