Documentation updates for 4.2 #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Craigacp
added
Oracle employee
pogren
reviewed
Dec 18, 2021
|
Congratulations 🎉🎉🎉🎉
…On Sat, Dec 18, 2021, 5:50 AM Philip Ogren ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In tutorials/external-models-tribuo-v4.ipynb
<#205 (comment)>:
> @@ -133,10 +133,7 @@
}
],
"source": [
- "var lrTrainer = new LinearSGDTrainer(new LogMulticlass(),new AdaGrad(0.1),3,30000,Trainer.DEFAULT_SEED);\n",
- "var lrModel = lrTrainer.train(mnistTrain);\n",
- "var lrEvaluation = labelFactory.getEvaluator().evaluate(lrModel,mnistTest);\n",
- "lrEvaluation.toString();"
this looks like a fat finger. "b" is not code per se....
—
Reply to this email directly, view it on GitHub
<#205 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWGLSQ3AAIHSNXL7X26OQ43URQAJZANCNFSM5KJRYP2Q>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
pogren
approved these changes
Dec 18, 2021
There was a problem hiding this comment.
- mostly documentation and other admin changes (e.g. update to .gitignore, new config.xml example files)
- code changes include Model.castModel is now a non-static member method that operates on 'this' rather than a parameter. Callers of this method updated.
- because there were lots of updates to the jupyter notebooks I fired them all up and rans as much of the code as I could (i.e. without setting up an OCI account.) Including the reproducibility notebook which requires JDK 17. Everything checks out!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Javadoc and markdown documentation updates for the 4.2 release, along with two new tutorials: onnx export and reproducibility.
Motivation
New features need docs.