Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a tutorial on multi-label problems and a configurable data source generator for multi-label demos. #166

Merged
merged 7 commits into from
Aug 31, 2021

Conversation

Craigacp
Copy link
Member

@Craigacp Craigacp commented Aug 31, 2021

Description

Adds a tutorial on multi-label problems showing the multi-label LinearSGDTrainer, the binary relevance based IndependentMultiLabelTrainer, a single classifier chain using ClassifierChainTrainer, and an ensemble of classifier chains using CCEnsembleTrainer.

It also adds a configurable data source generator for multi-label data.

Note the configurable data source won't provenance correctly until Tribuo depends on a version of OLCUT with this PR merged (oracle/olcut#37), and so it's not part of the unit tests yet.

Motivation

We'd like tutorials for each prediction type in Tribuo and multi-label was the last type without a tutorial.

It also adds the last configurable data source needed to round out the set of demo sources for each prediction type (see #160 for longer motivation).

@Craigacp Craigacp added the Oracle employee This PR is from an Oracle employee label Aug 31, 2021
pogren
pogren previously approved these changes Aug 31, 2021
Copy link
Member

@pogren pogren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most of the code changes look minor - mostly javadoc updates and small updates like e.g. the return type of GaussianAnomalyDataSource.generateDataset - which is now MutableDataset rather than Dataset. The one major code update is the new class MultiLabelGaussianDataSource which I looked over but didn't study closely. I made a bunch of comments in the slack channel about various edits to the tutorial. So, before you merge this PR don't forget to make those updates!

Copy link
Member

@pogren pogren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updates the tutorial look good! well written and easy to follow.

@Craigacp Craigacp merged commit 912cf75 into oracle:main Aug 31, 2021
@Craigacp Craigacp deleted the multilabel-tutorial branch August 31, 2021 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Oracle employee This PR is from an Oracle employee
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants