Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade NaN to 2.3 for Node6 support. #419

Closed
wants to merge 1 commit into from
Closed

Upgrade NaN to 2.3 for Node6 support. #419

wants to merge 1 commit into from

Conversation

asaf
Copy link

@asaf asaf commented Apr 28, 2016

Fixes #418

@cjbj
Copy link
Member

cjbj commented Apr 28, 2016

@asaf thanks for taking time to submit this. You would need to sign the OCA before it could be accepted. However, since we made the same code change already yesterday to our internal repo I will just close this PR as it is now redundant. I hope we get other PRs from you in future!

@cjbj cjbj closed this Apr 28, 2016
@asaf
Copy link
Author

asaf commented Apr 29, 2016

@cjbj that's good enough for me, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
oca-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asaf @cjbj