chore: improve the malicious metadata check #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
behnazh-w
force-pushed
the
behnazh/refactor-python-mal-check
branch
3 times, most recently
from
96fbbbf to
f80e70e
Compare
Signed-off-by: behnazh-w <[email protected]>
Signed-off-by: behnazh-w <[email protected]>
Signed-off-by: behnazh-w <[email protected]>
Signed-off-by: behnazh-w <[email protected]>
Signed-off-by: behnazh-w <[email protected]>
Signed-off-by: behnazh-w <[email protected]>
Signed-off-by: behnazh-w <[email protected]>
Signed-off-by: behnazh-w <[email protected]>
Signed-off-by: behnazh-w <[email protected]>
behnazh-w
force-pushed
the
behnazh/refactor-python-mal-check
branch
from
cf3ffac to
693d79a
Compare
tromai
reviewed
Jul 25, 2024
tromai
reviewed
Jul 25, 2024
tromai
reviewed
Jul 26, 2024
tromai
reviewed
Jul 26, 2024
tromai
reviewed
Jul 26, 2024
tromai
reviewed
Jul 26, 2024
tromai
reviewed
Jul 26, 2024
tromai
reviewed
Jul 26, 2024
benmss
reviewed
Jul 26, 2024
tromai
reviewed
Jul 26, 2024
tromai
reviewed
Jul 26, 2024
Signed-off-by: behnazh-w <[email protected]>
tromai
reviewed
Jul 26, 2024
tromai
reviewed
Jul 26, 2024
src/macaron/slsa_analyzer/checks/detect_malicious_metadata_check.py
Outdated
Show resolved
Hide resolved
Signed-off-by: behnazh-w <[email protected]>
tromai
reviewed
Jul 29, 2024
benmss
reviewed
Jul 29, 2024
tromai
reviewed
Jul 29, 2024
tromai
reviewed
Jul 29, 2024
tests/slsa_analyzer/checks/resources/pypi_files/zlibxjson-8.2.source
Outdated
Show resolved
Hide resolved
tromai
reviewed
Jul 29, 2024
Signed-off-by: behnazh-w <[email protected]>
tromai
reviewed
Jul 30, 2024
Signed-off-by: behnazh-w <[email protected]>
benmss
approved these changes
Jul 30, 2024
art1f1c3R
pushed a commit
that referenced
this pull request
Nov 29, 2024
This PR refactors and improves the _detect_malicious_metadata_check: * Moves the check under src/macaron/slsa_analyzer/checks/ * Refactors the implementation of the check to avoid storing the metadata in the PyPIRegistry object and uses the * AssetLocator representation instead. * Uses DB JSON type to store the serialized metadata info instead of dumping it as a string value. * Adds a new unit test for the check and improves the other relevant tests. * Adds the check to the django integration test case and its dependencies. * Ensures that the source code retrieved by the PyPIRegistry API is the version that matches the artifact PURL. * Removes the heuristics that introduce too many FPs. Signed-off-by: behnazh-w <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors and improves the
_detect_malicious_metadata_check:src/macaron/slsa_analyzer/checks/PyPIRegistryobject and uses theAssetLocatorrepresentation instead.JSONtype to store the serialized metadata info instead of dumping it as a string value.djangointegration test case and its dependencies.PyPIRegistryAPI is the version that matches the artifact PURL.