[New Doc PR] - SE Guides Menu Inconsistencies #4510 #4527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spericas
reviewed
Jul 13, 2022
spericas
reviewed
Jul 13, 2022
spericas
approved these changes
Jul 14, 2022
|
|
||
| [CARD] | ||
| .OIDC Guide | ||
| [link=security-oidc.adoc] |
There was a problem hiding this comment.
I think this should use xref instead of link (all of references), so it gets validated by build
There was a problem hiding this comment.
@romain-grecourt, how should we switch it to xref here?
[xref=dbclient.adoc] - does not work in CARD
xref:dbclient.adoc[] - does not work as well
There was a problem hiding this comment.
link is correct if used inside CARD component. Sample:
//DBClient
[CARD]
.DB Client
[icon=storage,link=dbclient.adoc]
--
Provides a unified, reactive API for working with databases in non-blocking way.
--
m0mus
approved these changes
Jul 15, 2022
romain-grecourt
pushed a commit
to MadsBrun/helidon
that referenced
this pull request
Jul 21, 2022
…n-io#4527) * Add missing cards to guides * Fix comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves "SE Guides Menu Inconsistencies" #4510