Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Doc PR] - SE Guides Menu Inconsistencies #4510 #4527

Merged
merged 2 commits into from
Jul 15, 2022
Merged

[New Doc PR] - SE Guides Menu Inconsistencies #4510 #4527

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9adde15
Add missing cards to guides
dalexandrov Jul 13, 2022
5244ae4
Fix comments
dalexandrov Jul 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions docs/se/guides/overview.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,41 @@ Learn how to use Helidon SE built-in and application metrics.
--
Learn how to trace a Helidon SE application.
--

[CARD]
.OIDC Guide
[link=security-oidc.adoc]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should use xref instead of link (all of references), so it gets validated by build

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@romain-grecourt, how should we switch it to xref here?

[xref=dbclient.adoc] - does not work in CARD
xref:dbclient.adoc[] - does not work as well

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link is correct if used inside CARD component. Sample:

//DBClient
[CARD]
.DB Client
[icon=storage,link=dbclient.adoc]
--
Provides a unified, reactive API for working with databases in non-blocking way.
--

--
Learn how to set up an OIDC Helidon SE application
--

[CARD]
.Helidon SE Upgrade Guide
[link=migration.adoc]
--
Learn how to Upgrade your Helidon SE application
--

[CARD]
.Helidon SE WebClient Guide
[link=webclient.adoc]
--
Learn how to use the Helidon SE Reactive WebClient
--

[CARD]
.Helidon SE DB Client Guide
[link=dbclient.adoc]
--
Learn how to use the Helidon SE Reactive DB Client
--

[CARD]
.Helidon SE Performance Tuning Guide
[link=performance-tuning.adoc]
--
Learn how to tune your Helidon SE application
--
====

== Build and Deploy
Expand Down