Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new issue templates for backport requests and community issues #9838

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zakkak
Copy link
Collaborator

@zakkak zakkak commented Oct 8, 2024

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Oct 8, 2024
label: Describe the motivation for the backport.
description: "Provide a clear and concise explanation of why this backport is needed. If it fixes a reported issue please link to it."
validations:
required: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zakkak \n ?
And an absolute nitpick: We know the rather limited set of versions to reasonably backport to, so how about dropdown ? https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/syntax-for-githubs-form-schema#about-githubs-form-schema

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't go for a dropdown because:

  1. I expect this to be used for Oracle GraalVM backport requests as well (where the version range is not as limited as in upstream
  2. I expect this to be used to request backports to branched versions as well while they are still being prepared for release (e.g. 24.2 right now), so we would need to update the dropdown every 6 months.

I will add the \n thanks

@zakkak zakkak force-pushed the 2024-10-08-community-issue-templates branch from b2ef061 to 324462e Compare October 11, 2024 08:26
@zakkak
Copy link
Collaborator Author

zakkak commented Nov 1, 2024

@fniephaus @alina-yur this is a kind reminder

@zakkak
Copy link
Collaborator Author

zakkak commented Nov 18, 2024

Hi @fniephaus @alina-yur , could one of you please have a look at this? Thanks

@alina-yur
Copy link
Member

@zakkak sorry for the delay. it's all good, I'll get to it tomorrow.

@alina-yur
Copy link
Member

Hi @zakkak, so here's the feedback for this PR. Seems like there are two issues to solve, let's do it in the following way.

@zakkak
Copy link
Collaborator Author

zakkak commented Nov 20, 2024

for 7_community_bug.yml, we suggest to move it to graalvm/graalvm-community-jdk21u, as this is more specific to community builds.

This seems to go against our initial decision to track all issues in oracle/graal. For that we would need to re-open the issues support in https://github.com/graalvm/graalvm-community-jdk21u. If we do so it would probably make more sense to have the backport requests (concerning that repository) there as well.

we would also suggest to remove the vendor labels to keep the community repo vendor-neutral.

I see how the dropdown might seem limiting, but I believe we will need some info regarding the build. I suggest keeping the field but making it a text field instead of a dropdown. WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement. redhat-interest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants