-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new issue templates for backport requests and community issues #9838
base: master
Are you sure you want to change the base?
Conversation
label: Describe the motivation for the backport. | ||
description: "Provide a clear and concise explanation of why this backport is needed. If it fixes a reported issue please link to it." | ||
validations: | ||
required: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zakkak \n
?
And an absolute nitpick: We know the rather limited set of versions to reasonably backport to, so how about dropdown
? https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/syntax-for-githubs-form-schema#about-githubs-form-schema
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't go for a dropdown because:
- I expect this to be used for Oracle GraalVM backport requests as well (where the version range is not as limited as in upstream
- I expect this to be used to request backports to branched versions as well while they are still being prepared for release (e.g. 24.2 right now), so we would need to update the dropdown every 6 months.
I will add the \n
thanks
b2ef061
to
324462e
Compare
@fniephaus @alina-yur this is a kind reminder |
Hi @fniephaus @alina-yur , could one of you please have a look at this? Thanks |
@zakkak sorry for the delay. it's all good, I'll get to it tomorrow. |
Hi @zakkak, so here's the feedback for this PR. Seems like there are two issues to solve, let's do it in the following way.
|
This seems to go against our initial decision to track all issues in
I see how the dropdown might seem limiting, but I believe we will need some info regarding the build. I suggest keeping the field but making it a text field instead of a dropdown. WDYT? |
Depends on #9825
cc @jerboaa @simonis @dchuyko