[GR-54241] Introduce reachability-metadata.json to replace the various existing -config.json files #9048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
…-config.json files
graalvmbot
force-pushed
the
lottet/GR-54241-strict-parser
branch
2 times, most recently
from
38e7322 to
987c983
Compare
zakkak
reviewed
Jun 6, 2024
Comment on lines
+282
to
+283
| "type": "string", | ||
| "default": [] |
There was a problem hiding this comment.
This is defined as type string but has a default value of an array.
What do you think about using:
"oneOf": [
{
"type": "string"
},
{
"type": "array",
"items": {
"type": "string"
}
}
],
"default": ""
like in comment?
There was a problem hiding this comment.
@zakkak we will implement your proposal in the follow-up PR. Your proposal seems more accurate.
|
@vjovanov do I understand correctly that this is going to be part of GraalVM for JDK 23 (24.1)? |
|
Yes, all changes made it for the release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a consolidated file for all reachability metadata necessary for Native Image programs.
The various parsers (subclasses of
ConfigurationParser) are split into aLegacy(Reflection)ConfigurationParserand a(Reflection)MetadataParser, which are able to parse the old and the new metadata formats, respectively.The builder now checks both locations to find metadata files, but only emits the new format from the agent and the
native-image-configuretool.