-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove most truffle dependencies from com.oracle.svm.graal
#5002
Conversation
779ac96
to
4e29c68
Compare
Hi @fniephaus, I am not sure who is the most suitable to review this kind of change. Thank you |
com.oracle.svm.graal
com.oracle.svm.graal
4e0a45b
to
eb1038b
Compare
Depends on oracle/graal#5002
0250c93
to
9ef53a1
Compare
Hi @pejovica, this is a kind reminder. |
a739edc
to
b3bfbbf
Compare
@fniephaus could we please revisit this? It still seems relevant. |
@zakkak We are currently working on a large refactoring to decouple Truffle from the compiler. The end result of this should be that only the |
Thanks for the update @christianwimmer. Do I understand correctly that this will also remove all the truffle related packages from the Furthermore, is this planned for the 23.1 release? Update: It looks like the answer to both questions is yes, see #6986 |
Implements `OptimizedAssumptionDependency` on top of `IsolatedCodeInstallBridge` in `com.oracle.svm.truffle` to avoid pulling truffle dependencies in `com.oracle.svm.graal`.
b3bfbbf
to
0a13043
Compare
The goal of this refactoring is described here: So in the future, truffle and all languages will be consumed from the application module-path. The compiler and SVM will still depend on truffle-compiler.jar, which is a small set of interfaces shared between Truffle and the compiler. It is not quite minimal yet (it still contains some libgraal specific classes), but we will work on further reducing it. |
No longer relevant. |
This PR tries to completely remove any dependencies on the truffle-api.jar for running
native-image
without runtime compilation support and truffle features.It:
com.oracle.svm.graal
graal/substratevm/src/com.oracle.svm.graal/src/com/oracle/svm/graal/meta/RuntimeCodeInstaller.java
Line 111 in 2f9a32b