[GR-38665] Avoid compile failures on AArch64 when full infopoints enabled #4565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@teshull @olpaw Could one of you please review this patch and see it through the Oracle gate? I tested this on AArch64 by modifying class SVMHost as described in the issue and it avoids the compile failures as expected. Proper testing will need to wait for the debuginfo lcoal vars patch to be included at which point enabling debug info will also enable full infopoint generation. |
olpaw
reviewed
May 11, 2022
substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/CalleeSavedRegisters.java
Show resolved
Hide resolved
adinn
force-pushed
the
aarch64_calleesave_patch
branch
from
cdcaa04 to
043c1a5
Compare
adinn
changed the title
olpaw
changed the title
olpaw
approved these changes
May 11, 2022
|
Running in internal CI now ... |
|
Thanks Paul. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes the problem reported in issue #4542.