Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow serialization config to contain java source style syntax classnames #3048

Closed

Conversation

kkriske
Copy link
Contributor

@kkriske kkriske commented Dec 5, 2020

Similar to how jni and reflection config files allow references like org.example.ClassName[] instead of [org.example.ClassName;, this should also be allowed for the serialization config.
The added code is copied from com.oracle.svm.hosted.config.ReflectionRegistryAdapter#resolveTypeResult which is where these cases for reflection/jni are handled.

@olpaw olpaw self-assigned this Dec 11, 2020
@olpaw
Copy link
Member

olpaw commented Dec 11, 2020

@kkriske Looks good. To get this faster to master I cherry-picked your commit onto another related PR I'm currently working on. See #3060

@olpaw
Copy link
Member

olpaw commented Dec 11, 2020

Your commit made it on master: 9e00386

@olpaw olpaw closed this Dec 11, 2020
@kkriske kkriske deleted the serialization-config-friendly-syntax branch July 16, 2021 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants