You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Combine work-request errors into single reconcileError event so that processing of this single recent event would provide information about the status of the machine. This is only for ocimachine events and not nlb/lb
The change is only the second commit, the previous commit are already merged into main branch. The output of unittests:
make test
fatal: No names found, cannot describe anything.
GOBIN=/home/opc/cluster-api-provider-oci/hack/tools/bin ./scripts/go_install.sh sigs.k8s.io/controller-runtime/tools/setup-envtest setup-envtest v0.0.0-20230131074648-f5014c077fc3
kube-builder assets: /home/opc/.local/share/kubebuilder-envtest/k8s/1.24.2-linux-amd64
KUBEBUILDER_ASSETS="/home/opc/.local/share/kubebuilder-envtest/k8s/1.24.2-linux-amd64" go test -coverprofile=coverage.out ./...
? github.com/oracle/cluster-api-provider-oci [no test files]
? github.com/oracle/cluster-api-provider-oci/cloud/config [no test files]
? github.com/oracle/cluster-api-provider-oci/cloud/metrics [no test files]
? github.com/oracle/cluster-api-provider-oci/cloud/scope/mocks [no test files]
? github.com/oracle/cluster-api-provider-oci/cloud/services/base [no test files]
? github.com/oracle/cluster-api-provider-oci/cloud/services/base/mock_base [no test files]
? github.com/oracle/cluster-api-provider-oci/cloud/services/compute [no test files]
? github.com/oracle/cluster-api-provider-oci/cloud/services/compute/mock_compute [no test files]
? github.com/oracle/cluster-api-provider-oci/cloud/services/computemanagement [no test files]
? github.com/oracle/cluster-api-provider-oci/cloud/services/computemanagement/mock_computemanagement [no test files]
? github.com/oracle/cluster-api-provider-oci/cloud/services/containerengine [no test files]
? github.com/oracle/cluster-api-provider-oci/cloud/services/containerengine/mock_containerengine [no test files]
? github.com/oracle/cluster-api-provider-oci/cloud/services/identity [no test files]
? github.com/oracle/cluster-api-provider-oci/cloud/services/identity/mock_identity [no test files]
? github.com/oracle/cluster-api-provider-oci/cloud/services/loadbalancer [no test files]
? github.com/oracle/cluster-api-provider-oci/cloud/services/loadbalancer/mock_lb [no test files]
? github.com/oracle/cluster-api-provider-oci/cloud/services/networkloadbalancer [no test files]
? github.com/oracle/cluster-api-provider-oci/cloud/services/networkloadbalancer/mock_nlb [no test files]
? github.com/oracle/cluster-api-provider-oci/cloud/services/vcn [no test files]
? github.com/oracle/cluster-api-provider-oci/cloud/services/vcn/mock_vcn [no test files]
? github.com/oracle/cluster-api-provider-oci/cloud/services/workrequests [no test files]
? github.com/oracle/cluster-api-provider-oci/cloud/services/workrequests/mock_workrequests [no test files]
? github.com/oracle/cluster-api-provider-oci/feature [no test files]
? github.com/oracle/cluster-api-provider-oci/version [no test files]
ok github.com/oracle/cluster-api-provider-oci/api/v1beta1 92.555s coverage: 23.4% of statements
ok github.com/oracle/cluster-api-provider-oci/api/v1beta2 0.053s coverage: 14.6% of statements
ok github.com/oracle/cluster-api-provider-oci/cloud/ociutil 0.025s coverage: 15.9% of statements
ok github.com/oracle/cluster-api-provider-oci/cloud/scope 22.261s coverage: 76.1% of statements
ok github.com/oracle/cluster-api-provider-oci/cloud/util 0.748s coverage: 61.1% of statements
ok github.com/oracle/cluster-api-provider-oci/controllers 2.559s coverage: 59.2% of statements
ok github.com/oracle/cluster-api-provider-oci/exp/api/v1beta1 32.768s coverage: 15.3% of statements
ok github.com/oracle/cluster-api-provider-oci/exp/api/v1beta2 0.065s coverage: 4.8% of statements
ok github.com/oracle/cluster-api-provider-oci/exp/controllers 0.996s coverage: 56.3% of statements
go tool cover -func=coverage.out -o coverage.txt
go tool cover -html=coverage.out -o coverage.html
OCA VerifiedAll contributors have signed the Oracle Contributor Agreement.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
oracle-contributor-agreement
bot
added
the
OCA Verified
Combine work-request errors into single reconcileError event so that processing of this single recent event would provide information about the status of the machine. This is only for ocimachine events and not nlb/lb
Related Fixes #383