Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added .adoc files to docs so that all the links are accessible #132

Closed

Conversation

syedthameem85
Copy link
Member

Proposed change

How has these changes been tested?

Automated testing

If you're running automated testing for this module, we would love to hear from you, and potentially integrate it to the module standard workflow.

Manual testing

If no automated testing is run, please ensure that at least the three steps below are passing without any error.

  • Running terraform apply on each example provided with this module provisions the intended resource(s) without any errors.
  • Modifying module's Input Variables after initial provisioning behaves as intended, i.e: any updateable properties are ameneded without recreation of the resource(s).
  • Running terraform destroy on each example provided with this module destroys all the resources created by this module and only the resources created by this module.

Checklist before submitting your PR

  • My code follows the style guidelines of this project
  • these changes provision new resources:
    • I have updated the README introduction section (README.adoc)
    • I have updated the README introduction section (README.md)
  • these changes adds any new variables:
  • I have updated the changelog to include an entry for these changes
  • I have updated all provided examples, including each README file and all applicable code blocks
  • these changes generates no new warnings
  • Any dependent changes have been merged and published in upstream modules

Note: If you are not an Oracle employee, to contribute to an Oracle-sponsored open-source project, you need to sign the Oracle Contributor Agreement (OCA).

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Dec 13, 2023
@syedthameem85
Copy link
Member Author

@hyder - This PR is for #117 which deals with fixing the broken links . Please review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant