Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support to allow attaching security lists in the subnet module. #106

Open
shb-mll opened this issue Mar 29, 2023 · 4 comments
Open

add support to allow attaching security lists in the subnet module. #106

shb-mll opened this issue Mar 29, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@shb-mll
Copy link

shb-mll commented Mar 29, 2023

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The subnet modules in its current state sets security_lists_ids to Null. This doesn't allow one to attach an existing SL to a subnet. ( line 26 in file https://github.com/oracle-terraform-modules/terraform-oci-vcn/blob/main/modules/subnet/subnet.tf)
Can we parameterise this and allow an input variable to provider security list id's ?
This enhancement will be very helpful.
If not could you provide a suggestion on how to attach an existing SL to a subnet via the module or with terraform a resource ?

New or Affected Resource(s)

oci_core_subnet

@shb-mll shb-mll added the enhancement New feature or request label Mar 29, 2023
@hyder
Copy link
Contributor

hyder commented Mar 30, 2023

@snafuz

@shb-mll
Copy link
Author

shb-mll commented Apr 4, 2023

@hyder @snafuz any suggestions on this ?

@shb-mll
Copy link
Author

shb-mll commented Apr 10, 2023

@hyder @devoncrouse @hyder @snafuz could you provide a suggestion for the above issue.

@bscarbrough
Copy link

Has there been any movement on this? I really have a need to do this, and there's no way to add security lists to subnets created with this module after the fact (at least not with Terraform).

syedthameem85 added a commit to syedthameem85/terraform-oci-vcn that referenced this issue Nov 20, 2023
syedthameem85 added a commit to syedthameem85/terraform-oci-vcn that referenced this issue Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants