Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ignore lifecycle changes, and use consistent fallback shape #51

Merged
merged 2 commits into from
Oct 8, 2022

Conversation

devoncrouse
Copy link
Contributor

@devoncrouse devoncrouse commented Oct 8, 2022

Proposed changes

Ignore lifecycle changes

  • availability_domain
  • defined_tags
  • metadata
  # module.bastion[0].oci_core_instance.bastion must be replaced
-/+ resource "oci_core_instance" "bastion" {
      ~ availability_domain                 = "aaaa:US-ASHBURN-AD-1" -> (known after apply) # forces replacement
~ metadata                            = {
    - "ssh_authorized_keys" = <<-EOT
          ssh-rsa ...
      EOT
    - "user_data"           = "..."
  } -> (known after apply) # forces replacement

Use consistent fallback shape

  • Use the same value for shape and shape_config to determine whether Flex
  • Use recent shape for both

Testing

Repeated apply, manually changing tags on resources and overriding the value returned by ad.name:

terraform apply
Apply complete! Resources: 3 added, 0 changed, 0 destroyed.

terraform apply
Apply complete! Resources: 0 added, 0 changed, 0 destroyed.

@devoncrouse devoncrouse requested a review from hyder October 8, 2022 01:20
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Oct 8, 2022
@hyder hyder merged commit 6317065 into oracle-terraform-modules:main Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants