Skip to content

Commit

Permalink
feat: Support disabled DNS record assignment for bastion subnet
Browse files Browse the repository at this point in the history
Signed-off-by: Devon Crouse <[email protected]>
  • Loading branch information
devoncrouse committed Dec 1, 2022
1 parent 6317065 commit de6d2bb
Show file tree
Hide file tree
Showing 3 changed files with 24 additions and 3 deletions.
15 changes: 15 additions & 0 deletions CHANGELOG.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,21 @@ All notable changes to this project are documented in this file.

The format is based on {uri-changelog}[Keep a Changelog].

= v3.1.4 (unreleased)
* feat: Support disabled DNS record assignment for bastion subnet by @devoncrouse

= v3.1.3 (October 7, 2022)
* fix: Ignore lifecycle changes, and use consistent fallback shape by @devoncrouse in #51

= v3.1.2 (October 5, 2022)
* fix: Compartment AD listing, ignore lifecycle changes by @devoncrouse in #50

= v3.1.1 (April 26, 2022)
* fix: made autonomous cloud init template optional. by @hyder in #49

= v3.1.0 (March 27, 2022)
* fix: Provider changed from hashicorp/oci to oracle/oci by @karthicgit in #47

= v3.0.0 (September 21, 2021)

== New features
Expand Down
4 changes: 2 additions & 2 deletions subnets.tf
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
# Copyright 2019, 2021 Oracle Corporation and/or affiliates. All rights reserved.
# Copyright 2019, 2022 Oracle Corporation and/or affiliates. All rights reserved.
# Licensed under the Universal Permissive License v 1.0 as shown at https://oss.oracle.com/licenses/upl/

resource "oci_core_subnet" "bastion" {
cidr_block = cidrsubnet(local.vcn_cidr, var.newbits, var.netnum)
compartment_id = var.compartment_id
display_name = var.label_prefix == "none" ? "bastion" : "${var.label_prefix}-bastion"
dns_label = "bastion"
dns_label = var.assign_dns ? "bastion" : null
freeform_tags = var.freeform_tags
prohibit_public_ip_on_vnic = var.bastion_type == "public" ? false : true
route_table_id = var.ig_route_id
Expand Down
8 changes: 7 additions & 1 deletion variables.tf
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright (c) 2019, 2021 Oracle Corporation and/or affiliates. All rights reserved.
# Copyright (c) 2019, 2022 Oracle Corporation and/or affiliates. All rights reserved.
# Licensed under the Universal Permissive License v 1.0 as shown at https://oss.oracle.com/licenses/upl

# provider parameters
Expand All @@ -20,6 +20,12 @@ variable "label_prefix" {
default = "none"
}

variable "assign_dns" {
default = true
description = "Whether to assign DNS records to created instances"
type = bool
}

# network parameters
variable "availability_domain" {
description = "the AD to place the bastion host"
Expand Down

0 comments on commit de6d2bb

Please sign in to comment.