Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code sample - Spring JdbcTemplate JDBC ADB UCP #318

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

juarezjuniorgithub
Copy link
Member

Code sample - Spring JdbcTemplate JDBC ADB UCP
Signed-off-by: Juarez Barbosa [email protected]

@juarezjuniorgithub juarezjuniorgithub force-pushed the jdbc-spring-jdbctemplate-oracle branch from f7e11e9 to 7185b44 Compare February 23, 2024 23:24
@juarezjuniorgithub
Copy link
Member Author

@Kuassim can you please approve it? Thanks in advance!

@gvenzl gvenzl requested a review from jeandelavarene April 19, 2024 17:20
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jun 19, 2024
@juarezjuniorgithub
Copy link
Member Author

@Kuassim @jeandelavarene the adjustments were performed as required - indentation fixed.
Please review, thanks.

public enum EmployeeMessages {

EMPLOYEE_CREATION_FAILED(
"Employee creation failed: "), EMPLOYEE_UPDATE_FAILED(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the format

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation is double-checked for all classes. Please note and remember the enforced format for String and enum data types as expected, per the IDE conventions we configured together. @Kuassim please review, thanks

public enum EmployeeSqlStatements {

FIND_ALL_EMPLOYEES("SELECT * FROM employee"), FIND_EMPLOYEE_BY_ID(
"SELECT * FROM employee WHERE id = :id"), CREATE_NEW_EMPLOYEE(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the format

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation is double-checked for all classes. Please note and remember the enforced format for String and enum data types as expected, per the IDE conventions we configured together. @Kuassim please review, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants