Fix #1837 RichTextEditor Content not re-Rendering #1848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change to the OnAfterRenderAsync method and changed OnInitialized to OnParametersSet
|
@leigh-pointer this fix seems to have broken some scenarios in the RichTextEditor. In 3.0.1 when I attempt to edit the content using the raw HTML tab (not the rich text editor tab) my changes are not recognized and are not saved. Upon further review, the RichTextEditor already has methods for RefreshRichText() and RefreshRawHtml() which were intended for the use cases where a developer needs to change the content programmatically and have it reflected in the editor. Perhaps that approach may be a better than trying to support changes to the Content parameter? |
|
@sbwalker I will look at this now. |
|
@leigh-pointer Steps to reproduce:
Result: the updated content is not reflected in the module |
sbwalker
added a commit
that referenced
this pull request
Dec 16, 2021
Rework to #1848 RawHTML not being saved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change to the OnAfterRenderAsync method and changed OnInitialized to OnParametersSet