Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix heading localization in TabPanel #1823

Merged
merged 1 commit into from
Nov 22, 2021
Merged

Fix heading localization in TabPanel #1823

merged 1 commit into from
Nov 22, 2021

Conversation

hishamco
Copy link
Contributor

Fixes #1811

@hishamco
Copy link
Contributor Author

@leigh-pointer can you try this if you have a time

@leigh-pointer
Copy link
Contributor

@hishamco I have tried it and looks pretty good and works as expected :)

@hishamco
Copy link
Contributor Author

Thanks @leigh-pointer, @sbwalker please merge

@sbwalker sbwalker merged commit df00f53 into oqtane:dev Nov 22, 2021
@hishamco hishamco deleted the tab-panel-localizer branch May 25, 2022 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Localization not working when using ResourceKey
3 participants
@hishamco @leigh-pointer @sbwalker