Merge pull request #1882 from leigh-pointer/#1880GetModuleDefinitionS…

…ettings #1880 Issue with new SettingService
oqtane · Dec 16, 2021 · e22606a · e22606a
2 parents bf56c2a + e034811
commit e22606a
Showing 1 changed file with 10 additions and 3 deletions.
diff --git a/Oqtane.Client/Services/SettingService.cs b/Oqtane.Client/Services/SettingService.cs
@@ -134,13 +134,20 @@ public async Task UpdateSettingsAsync(Dictionary<string, string> settings, strin
                 bool ispublic = false;
                 if (value.StartsWith("[Public]"))
                 {
-                    if (entityName == EntityNames.Site)
+                    switch (entityName)
                     {
-                        ispublic = true;
+                        case EntityNames.Site:
+                        case EntityNames.ModuleDefinition:
+                            ispublic = true;
+                            break;
+                        default:
+                            ispublic = false;
+                            break;
                     }
-                    value = value.Substring(8); // remove [Public]
+                    value = value.Substring(8); // remove [Public]                   
                 }
 
+
                 Setting setting = settingsList.FirstOrDefault(item => item.SettingName.Equals(kvp.Key, StringComparison.OrdinalIgnoreCase));
                 if (setting == null)
                 {