Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore FallbackResource #25

Merged
merged 1 commit into from
Aug 11, 2020
Merged

Restore FallbackResource #25

merged 1 commit into from
Aug 11, 2020

Conversation

smortex
Copy link
Member

@smortex smortex commented Aug 10, 2020

It is used to load an URL when not clicking links from the home page
(e.g. when loading a page from a link or bookmarks). The rest of
navigation was unaffected because the front UI change the address in the
address bar on each clic.

For it to work, PassengerHighPerformance must be turned off.

The current version of the apache module does not handle this properly
ATM, but this only affects users enabling PassengerHighPerformance.

It is used to load an URL when not clicking links from the home page
(e.g. when loading a page from a link or bookmarks).  The rest of
navigation was unaffected because the front UI change the address in the
address bar on each clic.

For it to work, PassengerHighPerformance must be turned off.

The current version of the apache module does not handle this properly
ATM, but this only affects users enabling PassengerHighPerformance.
@smortex smortex requested a review from a team as a code owner August 10, 2020 01:07
@smortex smortex added bug Something isn't working ignore labels Aug 10, 2020
@smortex
Copy link
Member Author

smortex commented Aug 10, 2020

Added the ignore label since the regression has not been part of any release yet.

The passenger_high_performance => false being ignored issue is fixed by puppetlabs/puppetlabs-apache#2058. we do not have to wait for it to be merged to merge this PR.

@neomilium neomilium merged commit 905072a into master Aug 11, 2020
@neomilium neomilium deleted the restore-fallbackresource branch August 11, 2020 07:20
@smortex smortex added the skip-changelog Excluded from CHANGELOG label Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working skip-changelog Excluded from CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants