FIx STL artifacts zip inside zip #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Pereira
added
area: cad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STL artifacts of GitHub action were being placed in a zip inside a zip.
In the same go I' have fixed DXF generation if they are included in the future. I saw that there were things on the workflow regarding DXFs that were doing things but they're output wasn't being used so I would rather delete it or complete it. I've chose to complete it making it conditionally export DXFs if there are any. I understood the script was like it was because currently we have no DXFs and we wanted to keep the code handy in the event we have DXFs again. Hope this is helpful!