Use tslib's PlotHistory in optuna-dashboard #928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keisuke-umezawa
force-pushed
the
feature/tslib-plothistory
branch
from
c039577 to
c1802ae
Compare
porink0424
requested changes
Aug 23, 2024
Comment on lines
-81
to
-114
| const element = document.getElementById(plotDomId) | ||
| if (element !== null && studies.length >= 1) { | ||
| // @ts-ignore | ||
| element.on("plotly_click", (data) => { | ||
| if (data.points[0].data.mode !== "lines") { | ||
| let studyId = 1 | ||
| if (data.points[0].data.name.includes("Infeasible Trial of")) { | ||
| const studyInfo: { id: number; name: string }[] = [] | ||
| studies.forEach((study) => { | ||
| studyInfo.push({ id: study.id, name: study.name }) | ||
| }) | ||
| const dataPointStudyName = data.points[0].data.name.replace( | ||
| "Infeasible Trial of ", | ||
| "" | ||
| ) | ||
| const targetId = studyInfo.find( | ||
| (s) => s.name === dataPointStudyName | ||
| )?.id | ||
| if (targetId !== undefined) { | ||
| studyId = targetId | ||
| } | ||
| } else { | ||
| studyId = studies[Math.floor(data.points[0].curveNumber / 2)].id | ||
| } | ||
| navigate( | ||
| url_prefix + | ||
| `/studies/${studyId}/trials?numbers=${data.points[0].x}` | ||
| ) | ||
| } | ||
| }) | ||
| return () => { | ||
| // @ts-ignore | ||
| element.removeAllListeners("plotly_click") | ||
| } |
There was a problem hiding this comment.
I think this part is missing in tslib/react/src/components/PlotHistory.tsx.
There was a problem hiding this comment.
I missed this part. Thank you.
|
@porink0424 I followed your suggestion, and implemented it like we did it for TrialTable. |
porink0424
approved these changes
Sep 11, 2024
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor License Agreement
This repository (
optuna-dashboard) and Goptuna share common code.This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.
Reference Issues/PRs
NA
What does this implement/fix? Explain your changes.
Use tslib's PlotHistory in optuna-dashboard