Show tick labels and add log scale in slice graph #90
Conversation
| tickfont: { | ||
| color: "#000000", | ||
| }, |
There was a problem hiding this comment.
[nits] Could you tell me what is this attribute for?
There was a problem hiding this comment.
This makes sure that the color of the x labels is black. It might not be strictly required, but since it was present in the non-numerical case, I added it here for consistency. If you want I can remove it in both places.
There was a problem hiding this comment.
By the way, there is a lot of duplicate code in the if(isnum) case and the else case. These cases basically only differ in the trace and the code could be simplyfied. I could do that if you want
There was a problem hiding this comment.
I have another question about the code. On line 177 you have xaxis: selected and on line 210 you have // xaxis: "paramName". So in one case (isnum) it is set and in the other case it is not. What is the effect of this parameter? I did not notice any difference when I commented it out, is it required?
There was a problem hiding this comment.
This makes sure that the color of the x labels is black. It might not be strictly required, but since it was present in the non-numerical case, I added it here for consistency. If you want I can remove it in both places.
I see. You are right 👍
By the way, there is a lot of duplicate code in the if(isnum) case and the else case. These cases basically only differ in the trace and the code could be simplyfied. I could do that if you want
Sounds good! Welcome.
There was a problem hiding this comment.
I'll make these changes in a separate PR because I don't know when I have time. Is everything in the current PR ok?
There was a problem hiding this comment.
I'll make these changes in a separate PR because I don't know when I have time. Is everything in the current PR ok?
Sure!
|
Great, thank you! And thanks for this nice tool :-) |
Contributor License Agreement
This repository (
optuna-dashboard) and Goptuna share common code.This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.
Reference Issues/PRs
No referenced issue as far as I know. I just found this a useful addition and I hope it helps other people too.
What does this implement/fix? Explain your changes.
There are two additions in the slice graph: