Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export App in optuna_dashboard #872

Merged
merged 16 commits into from
Jul 10, 2024
Merged

Export App in optuna_dashboard #872

merged 16 commits into from
Jul 10, 2024

Conversation

porink0424
Copy link
Collaborator

@porink0424 porink0424 commented Apr 26, 2024

Contributor License Agreement

This repository (optuna-dashboard) and Goptuna share common code.
This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.

  • I agree this patch may be ported to Goptuna by other Goptuna contributors.

Reference Issues/PRs

The same approach as in #880 was used.

What does this implement/fix? Explain your changes.

  • Exported the content of optuna_dashboard/ts as @optuna/optuna-dashboard
  • Created and added vite_dashboard as a sample project to install @optuna/optuna-dashboard into.
  • Changed to use the stable Grid since Unstable_Grid2 throws an error Uncaught TypeError: styled_default is not a function

@c-bata c-bata self-assigned this Jun 14, 2024
@porink0424 porink0424 changed the title [Draft] Export App in optuna_dashboard Export App in optuna_dashboard Jun 28, 2024
@porink0424 porink0424 marked this pull request as ready for review June 28, 2024 09:48
@porink0424 porink0424 requested a review from c-bata June 28, 2024 09:52
Copy link
Member

@c-bata c-bata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@c-bata c-bata merged commit 61c1158 into optuna:main Jul 10, 2024
10 checks passed
@porink0424 porink0424 deleted the feat/jupyter branch July 10, 2024 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants